Miscellaneous Omnipod code improvements & cleanup#135
Conversation
+ Remove unneeded & redundant didSend() & didReceive() message logging + Improved and additional PodState debugDescription display for insulin values + Improved pod suspend testing when updating delivery status + Update suspended, bolusing, tempBasalRunning, extendedBolusRunning definitions for better efficency and clarity using @dnzxy suggestion on OmniBLE PR #123 + Use supportedTempBasalRates var for better OmniKit consistency
StatusAll tests successful. LGTM. Code ReviewCode reviewed completed. Only comment was sent via PM to change units to U/hr. TestMost of the changes were cosmetic (consistent comments for OmniBLE and OmniKit, log info instead of log error, preferred formatting of the suspended, bolusing, tempBasalRunning, and extendedBolusRunning public var in Test Issue Report ChangesTo compare to Loop 3.4.4 with no modifications - use my personal report for comparison.
Test supportedTempBasalRatesVerify the manual temp basal rates are enacted as expected. Set manual temp basal for several rates. Confirm the Hex command sent to rPi matches expected value.
|
for better efficency and clarity using @dnzxy suggestion on OmniBLE PR Fix handling of comms error on resume & all pod DeliveryStatus cases #123