Skip to content

Logic fix for 049 pod fault with concurrent temp basal commands#140

Merged
marionbarker merged 1 commit into
LoopKit:devfrom
itsmojo:concurrent-TB-logic-fixes
Jan 18, 2025
Merged

Logic fix for 049 pod fault with concurrent temp basal commands#140
marionbarker merged 1 commit into
LoopKit:devfrom
itsmojo:concurrent-TB-logic-fixes

Conversation

@itsmojo
Copy link
Copy Markdown

@itsmojo itsmojo commented Jan 18, 2025

  • Fixes Trio issue #455, see for more details
  • Tweaks to runTemporaryBasalProgram() to avoid using stale podState
  • Change enactBolus() to use same updated pod suspended testing logic

+ Fixes Trio issue #455, see for more details
+ Tweaks to runTemporaryBasalProgram() to avoid using stale podState
+ Change enactBolus() to use same updated pod suspended testing logic
Copy link
Copy Markdown
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status

This update is accepted by code review.

Code Review

  • The 0x31 fix in the runTemporaryBasalProgram function comes from replacing the stale podState (from line 1952) before the lock (at runSession) with the podState obtained inside the lock (line 1992) which can be used for subsequent podState checks
  • The modification to the enactBolus function was not required but is good form to match the syntax of the runTemporaryBasalProgram function

Tests

Both Trio and Loop were built with this modification included. The code ran, as expected, with no issues. Various pod commands were exercised using an rPi DASH simulator.

@marionbarker marionbarker requested a review from ps2 January 18, 2025 17:43
marionbarker
marionbarker approved these changes Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants