Skip to content

Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)#28

Merged
marionbarker merged 1 commit into
LoopKit:mainfrom
itsmojo:pod-setup-resume-retry-prevention
Apr 2, 2024
Merged

Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)#28
marionbarker merged 1 commit into
LoopKit:mainfrom
itsmojo:pod-setup-resume-retry-prevention

Conversation

@itsmojo
Copy link
Copy Markdown
Contributor

@itsmojo itsmojo commented Mar 8, 2024

  • Have PairAndPrime ViewModel do an automatic retry on error
  • Have InsertCannula ViewModel do an automatic retry on error
  • Add resumingPodSetup func to attempt a getStatus and sleep on errors
  • Added some improved and updated pumpManager comments
  • Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
  • Correct & relocate OmniKit insulinType guard as per OmniBLE
  • Update OmniKit SessionsRunResult variable use to match OmniBLE

+ Have PairAndPrime ViewModel do an automatic retry on error
+ Have InsertCannula ViewModel do an automatic retry on error
+ Add resumingPodSetup func to attempt a getStatus and sleep on errors
+ Added some improved and updated pumpManager comments
+ Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
+ Correct & relocate OmniKit insulinType guard as per OmniBLE
+ Update OmniKit SessionsRunResult variable use to match OmniBLE
@marionbarker
Copy link
Copy Markdown
Collaborator

marionbarker commented Mar 18, 2024

Code review:
side-by-side review of OmniKit and OmniBLE
There are a few differences in the PR but these make the OmniKit more similar to the OmniBLE code.

Testing:
This was tested with the rPI DASH simulator under the OmniBLE version. (See LoopKit/OmniBLE#114 (comment))

I did not burn an Eros pod to test directly.

@marionbarker marionbarker requested a review from ps2 March 30, 2024 03:13
@marionbarker marionbarker merged commit 7116926 into LoopKit:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants