Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)#28
Merged
marionbarker merged 1 commit intoApr 2, 2024
Conversation
Contributor
itsmojo
commented
Mar 8, 2024
- Have PairAndPrime ViewModel do an automatic retry on error
- Have InsertCannula ViewModel do an automatic retry on error
- Add resumingPodSetup func to attempt a getStatus and sleep on errors
- Added some improved and updated pumpManager comments
- Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
- Correct & relocate OmniKit insulinType guard as per OmniBLE
- Update OmniKit SessionsRunResult variable use to match OmniBLE
+ Have PairAndPrime ViewModel do an automatic retry on error + Have InsertCannula ViewModel do an automatic retry on error + Add resumingPodSetup func to attempt a getStatus and sleep on errors + Added some improved and updated pumpManager comments + Have pumpManager detect pod setup resumes to invoke resumingPodSetup() + Correct & relocate OmniKit insulinType guard as per OmniBLE + Update OmniKit SessionsRunResult variable use to match OmniBLE
Collaborator
|
Code review: Testing: I did not burn an Eros pod to test directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.