Skip to content

Use environment for appName and replace hardcoded Loop with appName#34

Merged
marionbarker merged 4 commits into
mainfrom
enable_appName
Apr 24, 2024
Merged

Use environment for appName and replace hardcoded Loop with appName#34
marionbarker merged 4 commits into
mainfrom
enable_appName

Conversation

@marionbarker
Copy link
Copy Markdown
Collaborator

@marionbarker marionbarker commented Apr 10, 2024

  1. Add code needed to use environment that ties appName to CFBundleDisplayName
  2. Replace the hard-coded "Loop" string with appName

Test:

  • Only two files use appName
    • The UncertainRecovery display was not tested (the OmniBLE version was)
    • The BeepPreference updates with the string appName in the file but I could not figure out how to get the environment variable included.

@marionbarker marionbarker marked this pull request as draft April 11, 2024 17:13
@marionbarker
Copy link
Copy Markdown
Collaborator Author

marionbarker commented Apr 11, 2024

The open PR 32 will modify some of these strings. Hold off on this for now.
Note to self - update for appName

  • BeepPreference.swift

Edited because PR 32 is now merged.

@marionbarker
Copy link
Copy Markdown
Collaborator Author

I believe this PR is good enough. The Uncertainty Recovery view should reflect appName (tested with OmniBLE, but not OmniKit). I was not able to solve the problem for BeepPreference, but used the same work-around as was used for OmniBLE.

The screen with this PR applied is identical to that seen in OmniBLE PR 120 in this comment:

@marionbarker marionbarker marked this pull request as ready for review April 18, 2024 23:29
@marionbarker marionbarker merged commit f51fe35 into main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant