Use environment for appName and replace hardcoded Loop with appName#34
Merged
Conversation
Collaborator
Author
|
The open PR 32 will modify some of these strings. Hold off on this for now.
Edited because PR 32 is now merged. |
Collaborator
Author
|
I believe this PR is good enough. The Uncertainty Recovery view should reflect appName (tested with OmniBLE, but not OmniKit). I was not able to solve the problem for BeepPreference, but used the same work-around as was used for OmniBLE. The screen with this PR applied is identical to that seen in OmniBLE PR 120 in this comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test: