Fix for pump manager returns bogus podSuspended#49
Merged
Conversation
* add self.tryToValidateComms to handle uncertain comms; * ensure podSuspended is only returned when actually suspended
…extra debug logging
itsmojo
approved these changes
Feb 11, 2025
Collaborator
Author
StatusLGTM Code inspectionThe changes for OmniKit exactly parallel the OmniBLE PR 141 changes. TestingMost of the testing was done with the rPi and the DASH version of the PR. Use a Trio-dev test phone (commit These are the functions that contain a call to tryToValidateComms (the new function):
Do some kind of test with each function. Put
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a problem reported by Trio users Trio Issue 468 in which the pump manager can sometimes report podSuspended following an uncertain comm event.
Background
An earlier PR #47 added one improvement for automatically recovering from uncertain comms but increased the incidence of the podSuspended being returned from the pump manager when the pod was not actually suspended.
Proposed Solution
This PR adds tryToValidateComms which, if successful, enables the pump manager to return the updated response from getStatus.
It also modifies some guard statements so that a podSuspended is only returned when the last message received from the pod indicates the pod is actually suspended.
The goal is to have the PumpManager return the true pod status, if possible.