Skip to content

add new sampling algorithm "mirostat"#142

Merged
LostRuins merged 1 commit intoLostRuins:concedofrom
h3ndrik:concedo
May 5, 2023
Merged

add new sampling algorithm "mirostat"#142
LostRuins merged 1 commit intoLostRuins:concedofrom
h3ndrik:concedo

Conversation

@h3ndrik
Copy link
Copy Markdown

@h3ndrik h3ndrik commented May 5, 2023

This makes the (new) mirostat sampler from ggml-org#1126 available. There are more sampling techniques and features in that pull request.

I'm not sure if i implemented this correctly, so have a look at it before merging ;-) This only applies to llama.

@LostRuins
Copy link
Copy Markdown
Owner

this implementation is incorrect. Mirostat is a replacement for stochastic samplers and cannot be used alongside with them.

I plan to eventually add it as a command line flag, but I cannot support it within the Kobold API until it is implemented officially at https://github.com/henk717/KoboldAI

@LostRuins LostRuins added the invalid This doesn't seem right label May 5, 2023
@LostRuins LostRuins merged commit 851f553 into LostRuins:concedo May 5, 2023
@LostRuins
Copy link
Copy Markdown
Owner

I ended up merging it, but converting it to a launcher flag instead.

@LostRuins LostRuins removed the invalid This doesn't seem right label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants