Release payjoin-flutter-0.22.0 - #46
Merged
Merged
Conversation
DanGould
marked this pull request as ready for review
January 2, 2025 18:49
DanGould
marked this pull request as draft
January 2, 2025 18:50
DanGould
marked this pull request as ready for review
January 2, 2025 18:51
Contributor
Author
|
bb-mobile depends on this branch as-is, so I recommend we merge this as-is so as not to force push this commit away, and then update to payjoin-ffi 0.22 in a new PR UNTIL bbmobile updates to whatever our next release is (a 0.22 release perhaps), this branch MUST remain as-is. |
kumulynja
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem where persisted Senders (payjoin/rust-payjoin#443) would resume in such a way that they would never find an async receiver's payjoin proposal.
This change fixes that, but should wait until we release payjoin 0.22
Which this takes by depending on payjoin-ffi 0.22 LtbLightning/payjoin-ffi#41