fix(history): Add support for LockupView content#1075
Open
dnicolson wants to merge 2 commits intoLuanRT:mainfrom
Open
fix(history): Add support for LockupView content#1075dnicolson wants to merge 2 commits intoLuanRT:mainfrom
dnicolson wants to merge 2 commits intoLuanRT:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
This code has worked reliably since the PR was created. In one history continuation, just 6 of 200 history items were of type |
absidue
reviewed
Dec 18, 2025
absidue
reviewed
Dec 18, 2025
Collaborator
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
As GitHub won't let me comment on specific lines on this pull request, I'll leave a comment like this instead.
Please use the YTNode.is() type guard instead of explicitly checking the type property and casting.
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Remove the stale label or comment or this will be closed in 2 days |
Contributor
Author
|
@absidue is it possible to reopen this please? It is a very useful fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
LockupViewcontent in the watch history in addition toVideocontent. It seems that recently YouTube started usingLockupViewcontent in almost every instance.