fix(Player): Fix signature algorithm extraction#832
Merged
LuanRT merged 1 commit intoLuanRT:mainfrom Dec 10, 2024
Merged
Conversation
6 tasks
|
This fixes the |
Contributor
|
I believe this is because the n-sig decipher is failing due to a missing variable. fyn = function(J) {
// ... nsig prelude.
if (typeof uwg === "undefined") return J; // This is triggered because uwg is not defined
// ...rest of nsig function.
}; fyn(nsig);To fix, add this replace call: nsig_function.result.replace(/if\(typeof [a-zA-Z0-9]*==="undefined"\)return [a-zA-Z0-9]*;/, '') |
Collaborator
Author
|
Okay so in conclusion this PR is working correctly, it's just that there are also issues with the nsig stuff that this PR wasn't intended to solve as it's for the sig stuff not nsig stuff. |
LuanRT
approved these changes
Dec 10, 2024
bcomnes
added a commit
to hifiwi-fi/yt-dlp-api
that referenced
this pull request
Dec 10, 2024
Float a build of LuanRT/YouTube.js#832 off v11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is probably a cleaner way to handle this but this gets it working.