Contentious constructs: rule registry, secondary recall metric, and failures-view feedback#27
Merged
Merged
Conversation
… failures-view feedback buttons
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 44.53% 46.23% +1.69%
==========================================
Files 28 29 +1
Lines 3460 3608 +148
==========================================
+ Hits 1541 1668 +127
- Misses 1919 1940 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a contentious-constructs layer. A contentious construct is one the reference engine accepts but a parser may reasonably reject, like the SQLite TCL bind variables (
$::x) and the duplicate target columns fromlemon-rs#102and#89. Strict, oracle-graded recall stays the headline number and is untouched. Rules are one TOML file each undercontentious/(tcl-variables,duplicate-target-columns,sqlite-nonstandard-alter), matched against a masked form or a named structural predicate, with a guard test keeping each honest, so adding one is a data-only change.bench.jsongainsrecall_excl_contentious_pct, shown as a grey sub-line under strict recall. On SQLite,sqlite3-parseris 99.78% strict and 100% excluding contentious, so its whole gap is these constructs. The failures view gains per-row buttons linking to three prefilled issue forms, and a row already tagged contentious shows a badge plus a dispute button.CONTRIBUTING.mdcovers adding rules.