feat(ds4): run CUDA and HIP expert parallelism in one process - #570
Merged
Conversation
davide221
marked this pull request as ready for review
August 2, 2026 18:38
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 21 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review fixes
Lucebox2 validation
Hardware: Strix Halo 128 GiB + RTX 3090 24 GiB.
BUILD_SHARED_LIBSreset correctly.Correctness
The meaningful all-6-expert mixed run placed 9,632 expert tensors on Strix and 1,376 on the 3090. Reference-exact mixed decode produced the same 128-token response hash as Strix-only:
0f785a7ffa406498aafb14553966eaed0f52220fed0f7cc016b66921d104d194That run measured 15.751 tok/s versus 21.452 tok/s for Strix-only. Reference-exact mode is intended for identity validation, not peak throughput.
Performance profile
The tuned top-4 mixed profile completed 5/5 deterministic 128-token runs at 48.059 tok/s median (47.444-49.136), with a stable response hash. A 1,956-token prompt plus 256-token decode measured 41.181 tok/s.
Top-4 routing, sparse prefill, and owner-local sums are explicit performance choices. Owner-local sums change floating-point association and are not the byte-identity mode.
Defaults and risk
Mixed CUDA+HIP execution and its performance switches remain disabled by default and documented as burn-in. Existing single-runtime builds do not load a peer module or enable heterogeneous scheduling.
Merge status
Ready for review. All six CI checks for the final hardening commit are green.