perf(dflash): add opt-in exact prefill bands - #590
Draft
cheese-cakee wants to merge 10 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This remains a hardware-gated draft for the DeepSeek V4 exact-prefill objective. It does not claim the 1.5x target, production-model correctness, or merge readiness.
DFLASH_DS4_EXACT_PREFILL_BANDS=1.--chunk 1, dense, sparse, decode, and speculative-verification behavior.--chunk 1remains the explicit escape hatch.Current head
3e98b468fee82dbc441c18c2b6073db3f35eeae0This is a real merge of the reviewed production remediation chain with upstream
mainat4cf58a04c9f6b7c117a54c09ab1cb004d13175c9. It retains current-main ROCTX, indexer, sparse-decode, 0731, and shared fused-width behavior.Only seven files differ from current main:
server/docs/DS4.mdserver/docs/ENVIRONMENT.mdserver/src/deepseek4/deepseek4_backend.cppserver/src/deepseek4/deepseek4_fused_verify.incserver/src/deepseek4/deepseek4_graph.cppserver/src/deepseek4/deepseek4_internal.hserver/tests/test_deepseek4_unit.cppDiagnostic trace producers, comparator/package tooling, evidence files, and local research documents are not included.
Verification
Current-head local negative control:
sm_89), Release, CUDA graphs enabled.dflash_serverandtest_deepseek4_unitbuild successfully from exact offline Block-Sparse-Attention/CUTLASS identities.test_deepseek4_unitexits 0, including output-intent, stale-logit, raw-ring, q4 FFN-order, nested graph-override, and graph-generation-guard regressions.git diff upstream/main..HEAD --checkpasses.Earlier Lucebox5 runs on the pre-merge remediation identities passed affected HIP/gfx1151 suites and bounded real-model comparators, and exposed/fixed several previously masked correctness defects. Those results are historical evidence for their exact binaries; they do not replace a fresh final-head production differential.
Performance
No qualifying performance result is available. No speedup or 1.5x claim is made.
The acceptance comparison remains the frozen matched four-cell run on Lucebox5:
The model, quantization, prompt, cache state, topology, clocks, power state, build inputs, correctness semantics, warmups, and sample order remain pinned. Timing stays closed until the fresh exact differential, loader smoke, official-source oracle, and correctness matrix pass.
Remaining gates
The older ROCMFP2 model can establish only that model's correctness and speed delta; it does not prove 0731 support or performance.