Skip pitch-shifting for percussive types, add result indexing#33
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNPITCHED_TYPESset insample_type.py(kick, snare, hihat, clap, cymbal, percussion, drum, fx). Pitch-shifting is skipped for these types across transform tools, kit builder, and pair scoring — BPM time-stretching still applies. Consolidates and replaces the oldONE_SHOT_TYPESin candidate search.indexfield, rendered as a numbered badge on sample cards. Agent instructions updated to resolve ordinal references ("the 3rd one", "Add wavesurfer.js waveform visualization to sample browser #2") from these indices.DEMO_WORKFLOWS.mdto use natural references (chore: bump all dependencies to latest versions #1, Add wavesurfer.js waveform visualization to sample browser #2) instead of[sample_id]placeholders, and documented the unpitched pitch-shift skip behavior.Changes
backend/src/samplespace/schemas/sample_type.py— AddedUNPITCHED_TYPESsetbackend/src/samplespace/agents/tools/transform_tools.py— Skip pitch-shift for unpitched typesbackend/src/samplespace/services/candidate_search.py— ReplaceONE_SHOT_TYPESwithUNPITCHED_TYPESbackend/src/samplespace/services/kit_builder.py— Gate key compat scoring on pitched typesbackend/src/samplespace/services/pair_scoring.py— Gate key scoring on pitched typesbackend/src/samplespace/agents/tools/formatting.py— Addindexto sample payloadsbackend/src/samplespace/agents/sample_agent.py— Agent instructions for ordinal resolutionfrontend/components/elements/sample-card.tsx— Render index badgeREADME.md,docs/DEMO_WORKFLOWS.md,docs/preference-learning-flow.md— Doc updatesTest Plan
match_to_contexton a drum loop — confirm "Pitch-shift skipped" message, BPM stretch still appliesmatch_to_contexton a tonal loop (bass, pad) — confirm pitch-shifting still works normallyuv run --directory backend pre-commit run --all-filespassespnpm -C frontend lintpasses🤖 Generated with Claude Code