Skip to content

Skip pitch-shifting for percussive types, add result indexing#33

Merged
LukeMainwaring merged 4 commits into
mainfrom
workflow-improvements-1
Apr 5, 2026
Merged

Skip pitch-shifting for percussive types, add result indexing#33
LukeMainwaring merged 4 commits into
mainfrom
workflow-improvements-1

Conversation

@LukeMainwaring

Copy link
Copy Markdown
Owner

Summary

  • Unpitched types: Define canonical UNPITCHED_TYPES set in sample_type.py (kick, snare, hihat, clap, cymbal, percussion, drum, fx). Pitch-shifting is skipped for these types across transform tools, kit builder, and pair scoring — BPM time-stretching still applies. Consolidates and replaces the old ONE_SHOT_TYPES in candidate search.
  • Result indexing: Search results now include a 1-based index field, rendered as a numbered badge on sample cards. Agent instructions updated to resolve ordinal references ("the 3rd one", "Add wavesurfer.js waveform visualization to sample browser #2") from these indices.
  • Demo workflow docs: Rewrote DEMO_WORKFLOWS.md to use natural references (chore: bump all dependencies to latest versions #1, Add wavesurfer.js waveform visualization to sample browser #2) instead of [sample_id] placeholders, and documented the unpitched pitch-shift skip behavior.

Changes

  • backend/src/samplespace/schemas/sample_type.py — Added UNPITCHED_TYPES set
  • backend/src/samplespace/agents/tools/transform_tools.py — Skip pitch-shift for unpitched types
  • backend/src/samplespace/services/candidate_search.py — Replace ONE_SHOT_TYPES with UNPITCHED_TYPES
  • backend/src/samplespace/services/kit_builder.py — Gate key compat scoring on pitched types
  • backend/src/samplespace/services/pair_scoring.py — Gate key scoring on pitched types
  • backend/src/samplespace/agents/tools/formatting.py — Add index to sample payloads
  • backend/src/samplespace/agents/sample_agent.py — Agent instructions for ordinal resolution
  • frontend/components/elements/sample-card.tsx — Render index badge
  • README.md, docs/DEMO_WORKFLOWS.md, docs/preference-learning-flow.md — Doc updates

Test Plan

🤖 Generated with Claude Code

@LukeMainwaring LukeMainwaring merged commit bde3694 into main Apr 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant