Conversation
nagmat84
approved these changes
Jun 29, 2022
nagmat84
left a comment
nagmat84
left a comment
Collaborator
There was a problem hiding this comment.
Luckily, this was a one-liner. But we should really get #1351merged (after I have gone through merging hell). #1351 contains a bunch of new tests for Imagick and GD incl. all sorts of auto-rotation in every combination. That why I added orientation-xxx.jpg and {h|v]flip.jpeg to tests/Samples. This will prevent us from problems like this in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first victim of merging #1336 is here 😉: the GD image handler didn't work anymore for images not requiring rotation...