Skip to content

Changed tutorial names#200

Merged
smk0033 merged 4 commits intodevelopfrom
science_name_changes-sk
May 23, 2023
Merged

Changed tutorial names#200
smk0033 merged 4 commits intodevelopfrom
science_name_changes-sk

Conversation

@smk0033
Copy link
Contributor

@smk0033 smk0033 commented May 18, 2023

Changed the science tutorial names. Ignore all of the other changes made to HLS for now, I started working on other tickets with that one. I also adjusted some of the file names

@smk0033 smk0033 requested review from jjfrench and wildintellect May 18, 2023 21:56
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wildintellect wildintellect requested a review from rtapella May 18, 2023 21:58
Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GEDI_02B and GEDI L2B are the same thing. For consistency we need to have the same naming style (I prefer the L2A L2B style).

  • Do the notebooks really need tutorial in their name?
  • What's the difference between the 02B and L2B notebooks?

As noted in slack, the HLS notebook changes should be removed from this branch before we can approve as it's not part of the task/ticket.

@jjfrench
Copy link
Member

@wildintellect, looks like Aimee's (02B) is a tutorial on using the STAC catalog while Nathan's (L2B) is using NASA CMR search

@wildintellect
Copy link
Collaborator

Are we keeping 02B in MAAP STAC @abarciauskas-bgse? I think we removed it as a duplicate of NASA CMR, so delist or delete the notebook?

Copy link
Contributor

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially this is fine. I don’t know enough about the details to comment more.

@smk0033
Copy link
Contributor Author

smk0033 commented May 19, 2023

@wildintellect I'll switch over the GEDI tutorials to use L instead of 0! As for the two L2B ones, is the CMR one going to be deleted as you suggested above? If not, I'll have to add something to differentiate the two (Like GEDI_L2B_stac and GEDI_L2B_cmr?)

@smk0033
Copy link
Contributor Author

smk0033 commented May 19, 2023

I'll also go ahead and remove "tutorial" from the file names so they'll just be the datasets

@smk0033
Copy link
Contributor Author

smk0033 commented May 19, 2023

New commit. Left GEDI_02B as-is in case it does get deleted, if not then I'll have to readjust the names to separate the GEDI_L2Bs. I also think I fixed the HLS file?

@smk0033
Copy link
Contributor Author

smk0033 commented May 22, 2023

Also updated GEDI_L4B to "Search and Visualize"

@smk0033 smk0033 merged commit 242770c into develop May 23, 2023
@smk0033 smk0033 deleted the science_name_changes-sk branch May 23, 2023 15:44
wildintellect added a commit that referenced this pull request May 24, 2023
#200 missed updating this index for the site navigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants