Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
Can you make it an internal page link? |
…links to download the files directly
Contributor
Author
|
2 tasks
wildintellect
approved these changes
Jun 30, 2023
Collaborator
wildintellect
left a comment
There was a problem hiding this comment.
I'm ok with these changes as an improvement over the current. However I have questions about finding a better way to surface the yaml examples. Option include putting the yaml in code blocks and adding a copy button #256 , pushing users to clone the repo (or automatically including it in workspaces), redirecting users to the github repo folder, or the current where it just opens in the browser window for copy/paste.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the documentation explaining how to update environments
See #251
Adds a reference to the page with the example config files
In https://github.com/MAAP-Project/maap-documentation/pull/197/files I had changed the way we were pointing to example conda configuration files. The intent was to have a notebook showing the content of these files and having this notebook as a separate page of the docs, with the explanation page pointing to the latter page for examples.
I had forgotten to reference that examples page, so it's not showing up in the docs.
Fixing that here. See my screenshot.