Skip to content

edav_wcs guidelines#326

Merged
smk0033 merged 5 commits intodevelopfrom
edav_wcs_guidelines
Sep 6, 2023
Merged

edav_wcs guidelines#326
smk0033 merged 5 commits intodevelopfrom
edav_wcs_guidelines

Conversation

@smk0033
Copy link
Contributor

@smk0033 smk0033 commented Sep 5, 2023

Reference issue/ticket: #281

Added new sections and updated the base WCS link. Also had to change the dataset since the coverage id 'test_afrisar_onera_ClopeTB10_biomass_COG' didn't seem to exist. Used ESACCI_Biomass_L4_AGB since Alex provided that as a test ID, but can also change.

@smk0033 smk0033 added the documentation Improvements or additions to documentation label Sep 5, 2023
@smk0033 smk0033 requested review from emileten and jjfrench September 5, 2023 19:01
@smk0033 smk0033 self-assigned this Sep 5, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 5, 2023

View / edit / reply to this conversation on ReviewNB

jjfrench commented on 2023-09-05T20:33:26Z
----------------------------------------------------------------

In the stac_ipyleaflet notebook, we make the workspace environment distinction like:

"Disclaimer: it is recommended to run this tutorial within MAAP's ADE Pangeo workspace, which already includes the stac_ipyleaflet package."

Maybe we could do this for the this notebook since we had issues with rioxarray? Or we could ask JPL to upgrade their pip version, at least that worked for me


smk0033 commented on 2023-09-06T16:59:17Z
----------------------------------------------------------------

I'll go ahead and recommend the Pangeo workspace, but it probably wouldn't hurt to ask JPL to upgrade their pip version. I'll go back and adjust if they do 🙂

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 5, 2023

View / edit / reply to this conversation on ReviewNB

jjfrench commented on 2023-09-05T20:33:27Z
----------------------------------------------------------------

Line #6.              alpha=.3,# transparancy 

Previous typo - *transparency


Copy link
Contributor Author

smk0033 commented Sep 6, 2023

I'll go ahead and recommend the Pangeo workspace, but it probably wouldn't hurt to ask JPL to upgrade their pip version. I'll go back and adjust if they do 🙂


View entire conversation on ReviewNB

@smk0033
Copy link
Contributor Author

smk0033 commented Sep 6, 2023

Updated and I think I rebased develop into the branch?

@smk0033 smk0033 merged commit dfc72d6 into develop Sep 6, 2023
@smk0033 smk0033 deleted the edav_wcs_guidelines branch September 6, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants