Conversation
grallewellyn
commented
Oct 25, 2023
grallewellyn
commented
- now tell users to use personal access token instead of password
- I removed the section https://docs.maap-project.org/en/latest/getting_started/writing_code.html#The-MAAP-GitLab-Code-repository because it was basically the same as the section above. I just added a note to the section above about cloning through MAAP GitLab
- work_with_git is now a one stop shop for all git information
- Used this google doc as a guide for rewriting section
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This might be a better place to mention gitignoring checkpoints? #350 (comment) |
I agree, just pushed changes |
| @@ -14,7 +14,7 @@ | |||
| ".. note::\n", | |||
There was a problem hiding this comment.
Something is wrong and the image links aren't rendering in this notebook in the new section.
Reply via ReviewNB
There was a problem hiding this comment.
They show up in the github preview but not the NB Review. The writing_code_overview.png shows up in both.
There was a problem hiding this comment.
@grallewellyn difference seems to be ../ added to the front of the partially working images, should probably just be _static/...
There was a problem hiding this comment.
Hmm I changed this because I moved all the clone_demo images from source/getting_started/_static/ to source/_static/ since I now also use the images in system_reference_guide
If I delete the build files and rebuild locally the images are still showing up
If I remove the ../ and delete the build files and rebuild locally the images don't show up
@wildintellect
There was a problem hiding this comment.
When I build locally, the images are working for me
There was a problem hiding this comment.
I am going to push this to the RtD site to test it out
There was a problem hiding this comment.
wildintellect
left a comment
wildintellect
left a comment
There was a problem hiding this comment.
Build works so lets go with it.
3 participants
