Conversation
… started giving error at the end all of a sudden.
- also cleaned up some broken links in other pages
…do that change due to a bug
v3.1.5 release notes
revoke docs | minor updates
- updated basedir command to be more cross-platform friendly
Dps tutorial v1
Fix relnotes 315
rtapella
requested review from
grallewellyn,
omshinde,
smk0033 and
wildintellect
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
omshinde
left a comment
omshinde
left a comment
There was a problem hiding this comment.
Thanks. The PR looks good to me. Zenodo DOI is also added. I didn't check individual notebooks as they must have been reviewed and approved during development.
|
@omshinde a key check at this stage is to check the website build to make sure nothing obvious is broken https://docs.maap-project.org/en/develop/ |
grallewellyn
left a comment
grallewellyn
left a comment
There was a problem hiding this comment.
Reviewed and
- images and links look good
- most tutorials look good
Pending issues:
- interval_color_mapping tutorial items_response returns not found
- we should change the stac_ipyleaflet tutorial to remove
# %pip install git+https://github.com/MAAP-Project/stac_ipyleaflet.git#egg-info=stac_ipyleafletbecause all images now include stac_ipyleaflet. The tutorial works with removing this line - one of the images are blurry and I created a PR to fix it here: #395
There was a problem hiding this comment.
For this tutorial, items_response = requests.get(f"{stac_endpoint}/collections/{collection}/items/{item}").json()
Returns {'code': 'NotFoundError', 'description': 'Collection NASA_JPL_global_agb_mean_2020 does not exist.'}
There was a problem hiding this comment.
oh that product was removed from MAAP, we'll need to change to a different product. Please make a ticket. at the same time we can also upgrade the document to use pystac client instead of direct requests
There was a problem hiding this comment.
is this an issue with the updated content in develop? is this a blocker on merging the PR, or is this a new issue that will go into a future push?
There was a problem hiding this comment.
No these issue would have existed regardless and should not block but be their own tickets for next round of fixes.
|
Seems like this is ready to push. |
|
resolves #278 |
8 participants
Release 3.1.5 of the workspaces is happening.
Use this timing to do a periodic merge from develop -> master and get docs related to the 3.1.5 release into production