Skip to content

New NISAR Notebook#401

Merged
smk0033 merged 7 commits intodevelopfrom
sim_nisar_doc
Jul 1, 2024
Merged

New NISAR Notebook#401
smk0033 merged 7 commits intodevelopfrom
sim_nisar_doc

Conversation

@smk0033
Copy link
Contributor

@smk0033 smk0033 commented May 8, 2024

Ticket: https://github.com/NASA-IMPACT/active-maap-sprint/issues/901

New Simulated NISAR notebook showing how to access NISAR data from the MAAP STAC. xarray and DataTree are used for exploration and visualization.

@smk0033 smk0033 requested review from jsignell and omshinde May 8, 2024 18:09
@smk0033 smk0033 self-assigned this May 8, 2024
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jsignell jsignell self-assigned this May 8, 2024
@review-notebook-app
Copy link

review-notebook-app bot commented May 9, 2024

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:25Z
----------------------------------------------------------------

The project team

It is unclear what this means. But I think you can just say "There are a set of sample products

the formate and metadata


smk0033 commented on 2024-05-09T19:31:42Z
----------------------------------------------------------------

I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out!

@review-notebook-app
Copy link

review-notebook-app bot commented May 9, 2024

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:26Z
----------------------------------------------------------------

Line #1.    !pip install -q h5netcdf

This should also be included in the pangeo image. So we don't need this line.


@review-notebook-app
Copy link

review-notebook-app bot commented May 9, 2024

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:27Z
----------------------------------------------------------------

Line #6.        os.mkdir(dataDir)

Instead of this if block you can use os.makedirs with exist_ok=True ref: https://docs.python.org/3/library/os.html#os.makedirs


@review-notebook-app
Copy link

review-notebook-app bot commented May 9, 2024

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:28Z
----------------------------------------------------------------

Line #2.    !wget -P {dataDir} {item_asset}

Do we really need to download the dataa? we can't just read it inplace from s3?


wildintellect commented on 2024-05-16T20:37:36Z
----------------------------------------------------------------

Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read.

@review-notebook-app
Copy link

review-notebook-app bot commented May 9, 2024

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:28Z
----------------------------------------------------------------

Replace first sentence with something like:

Finally, let's visualize our data using matplotlib via .plot(). Given what we discovered by inspecting the DataTree above, we know that we are interested in the "HH" group. So when we open the dataset we can specify exactly that group.

Alternatively I bet you could just keep using the datatree object dt that you specified above. It looks like you can probably replace the first line in the cell below with something like:

ds = dt["science/LSAR/GUNW/grids/frequencyA/pixelOffsets/HH"].ds


@jsignell jsignell removed their assignment May 9, 2024
Copy link
Contributor Author

smk0033 commented May 9, 2024

I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out!


View entire conversation on ReviewNB

@smk0033
Copy link
Contributor Author

smk0033 commented May 10, 2024

Thank you for all of your feedback, Julia! I'll work on getting all of that incorporated!

Copy link
Collaborator

Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read.


View entire conversation on ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented May 16, 2024

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2024-05-16T20:37:55Z
----------------------------------------------------------------

Change to the GCOV product.


@smk0033
Copy link
Contributor Author

smk0033 commented Jun 25, 2024

@jsignell I think this is ready for another review when you have some time!

@smk0033 smk0033 requested a review from wildintellect June 25, 2024 03:05
@smk0033
Copy link
Contributor Author

smk0033 commented Jun 25, 2024

@nemo794 we would also appreciate your comments on this notebook for the new simulated NISAR data. Thanks in advance!

@smk0033 smk0033 requested a review from chuckwondo June 26, 2024 16:45
@smk0033 smk0033 requested a review from chuckwondo June 26, 2024 19:14
@@ -0,0 +1,11823 @@
{
Copy link

@chuckwondo chuckwondo Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of, If you would like ... click here., let's go with this (using "click here" is a hyperlink anti-pattern, as the linked text "here" is not descriptive of what it links to):

For more information, see [Authentication: Before we can use earthaccess we need an account with NASA EDL](https://nasa-openscapes.github.io/earthdata-cloud-cookbook/tutorials/earthaccess-demo.html#authentication-before-we-can-use-earthaccess-we-need-an-account-with-nasa-edl)


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is noted - thanks! 🙂

@smk0033 smk0033 requested a review from chuckwondo June 28, 2024 21:04
Copy link

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sheyenne!

@smk0033 smk0033 merged commit 17603c1 into develop Jul 1, 2024
@smk0033 smk0033 deleted the sim_nisar_doc branch July 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants