Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB jsignell commented on 2024-05-09T19:23:25Z The project team It is unclear what this means. But I think you can just say "There are a set of sample products
the format smk0033 commented on 2024-05-09T19:31:42Z I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out! |
|
View / edit / reply to this conversation on ReviewNB jsignell commented on 2024-05-09T19:23:26Z Line #1. !pip install -q h5netcdf This should also be included in the pangeo image. So we don't need this line. |
|
View / edit / reply to this conversation on ReviewNB jsignell commented on 2024-05-09T19:23:27Z Line #6. os.mkdir(dataDir) Instead of this if block you can use |
|
View / edit / reply to this conversation on ReviewNB jsignell commented on 2024-05-09T19:23:28Z Line #2. !wget -P {dataDir} {item_asset}
Do we really need to download the dataa? we can't just read it inplace from s3? wildintellect commented on 2024-05-16T20:37:36Z Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read. |
|
View / edit / reply to this conversation on ReviewNB jsignell commented on 2024-05-09T19:23:28Z Replace first sentence with something like:
Finally, let's visualize our data using
Alternatively I bet you could just keep using the datatree object
|
|
I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out! View entire conversation on ReviewNB |
|
Thank you for all of your feedback, Julia! I'll work on getting all of that incorporated! |
|
Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read. View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2024-05-16T20:37:55Z Change to the GCOV product. |
|
@jsignell I think this is ready for another review when you have some time! |
|
@nemo794 we would also appreciate your comments on this notebook for the new simulated NISAR data. Thanks in advance! |
| @@ -0,0 +1,11823 @@ | |||
| { | |||
There was a problem hiding this comment.
Instead of, If you would like ... click here., let's go with this (using "click here" is a hyperlink anti-pattern, as the linked text "here" is not descriptive of what it links to):
For more information, see [Authentication: Before we can use earthaccess we need an account with NASA EDL](https://nasa-openscapes.github.io/earthdata-cloud-cookbook/tutorials/earthaccess-demo.html#authentication-before-we-can-use-earthaccess-we-need-an-account-with-nasa-edl)
Reply via ReviewNB
There was a problem hiding this comment.
That is noted - thanks! 🙂
Ticket: https://github.com/NASA-IMPACT/active-maap-sprint/issues/901
New Simulated NISAR notebook showing how to access NISAR data from the MAAP STAC.
xarrayandDataTreeare used for exploration and visualization.