Skip to content

Added intro paragraphs to each major section of the docs#440

Merged
rtapella merged 3 commits intodevelopfrom
doc-section-intros
Oct 15, 2024
Merged

Added intro paragraphs to each major section of the docs#440
rtapella merged 3 commits intodevelopfrom
doc-section-intros

Conversation

@rtapella
Copy link
Contributor

@rtapella rtapella commented Oct 9, 2024

Issue:
#168

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@grallewellyn grallewellyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular blockers, but some suggestions to consider to change the phrasing and focus.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the need for this header level change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the conclusion didn't show up in the left-hand navigation tree b/c it was lower-level. I didn't think it deserved its own page. But it felt like it should look like an "end" section in the navigation list.

Do you buy that? 😆

- thank you for the feedback wildintellect
@rtapella rtapella merged commit 0fd86d0 into develop Oct 15, 2024
@rtapella rtapella deleted the doc-section-intros branch October 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants