fix: prefer app bundle name over sdef dictionary title#15
Conversation
The sdef dictionary title (e.g. 'Mail Terminology') was used as the adapter name, propagating through the entire pipeline. Now prefers: --app flag > bundle name from .app path > dictionary title. Closes #14
|
@claude review this PR — fixes sdef interrogator to prefer app bundle name over dictionary title |
|
Claude finished @mickdarling's task in 1m 0s —— View job PR Review
Overall: LGTM — clean, focused fix. The change is correct and the priority order makes intuitive sense. What changed
Previously the name was resolved inline as Correctness
Minor observations
Test plan coverageThe three test cases in the PR description cover the happy path, the path-derived case, and the fallback — that's exactly the right set. No issues blocking merge. |
Summary
The sdef interrogator used the
<dictionary title="Mail Terminology">attribute as the adapter name. This propagated through the entire pipeline, producing@mcpaql/generated-Mail Terminology-adapteras the package name.Now uses priority order:
--appflag > app name from.appbundle path > dictionary title.Closes #14
Test plan
--app Mailproducesname: "Mail"in discovery bundle--sdef /path/to/Mail.app/.../Mail.sdef(no --app) producesname: "Mail"from path.appsegment🤖 Generated with Claude Code