Skip to content

fix travis file (tab -> space)#2234

Merged
tylerjereddy merged 2 commits into
developfrom
fix-broken-travis-2233
Apr 3, 2019
Merged

fix travis file (tab -> space)#2234
tylerjereddy merged 2 commits into
developfrom
fix-broken-travis-2233

Conversation

@orbeckst

@orbeckst orbeckst commented Apr 3, 2019

Copy link
Copy Markdown
Member

Fixes #2233

Changes made in this Pull Request:

  • changed a stupid TAB to spaces (TAB was introduced in 4f8dc17)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@orbeckst

orbeckst commented Apr 3, 2019

Copy link
Copy Markdown
Member Author

@MDAnalysis/coredevs please ok look at this PR so that testing can resume.

Once this is merged, I also have to update a bunch of PRs so that they run the tests properly

(It's soooooo embarrassing having to alert everyone to my own stupidity...)

@codecov

codecov Bot commented Apr 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2234 into develop will decrease coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2234      +/-   ##
===========================================
- Coverage    90.71%   89.57%   -1.15%     
===========================================
  Files           15      158     +143     
  Lines         1982    19687   +17705     
  Branches         0     2769    +2769     
===========================================
+ Hits          1798    17634   +15836     
- Misses         184     1458    +1274     
- Partials         0      595     +595
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/GRO.py 93.87% <0%> (ø)
package/MDAnalysis/coordinates/base.py 93.3% <0%> (ø)
package/MDAnalysis/analysis/helanal.py 85.19% <0%> (ø)
package/MDAnalysis/topology/MinimalParser.py 100% <0%> (ø)
package/MDAnalysis/visualization/__init__.py 100% <0%> (ø)
package/MDAnalysis/core/qcprot.py 100% <0%> (ø)
...e/MDAnalysis/analysis/encore/clustering/cluster.py 96.22% <0%> (ø)
package/MDAnalysis/coordinates/DCD.py 97.16% <0%> (ø)
package/MDAnalysis/coordinates/GSD.py 85.1% <0%> (ø)
package/MDAnalysis/coordinates/memory.py 96.02% <0%> (ø)
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a60c8a...bb54223. Read the comment docs.

@orbeckst

orbeckst commented Apr 3, 2019

Copy link
Copy Markdown
Member Author

Argh, the doc issue has not been fixed, see https://travis-ci.com/MDAnalysis/mdanalysis/jobs/189877496

@orbeckst orbeckst mentioned this pull request Apr 3, 2019
* pin the version of sphinx used
in Travis doc builds until upstream
issues are resolved in version 2.0
@tylerjereddy

Copy link
Copy Markdown
Member

I pushed a commit to (hopefully) pin sphinx to version 1.8.5, which has been a common strategy in the last few days upstream, until a few matters can be resolved.

@tylerjereddy tylerjereddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs are building properly again now with the sphinx version pin; a few warnings, but that's probably normal

I'll merge this in to fix CI--we can adopt bleeding edge sphinx version when upstream fixes are in

codecov failure is garbage

@tylerjereddy tylerjereddy merged commit 7dfb65a into develop Apr 3, 2019
@tylerjereddy tylerjereddy deleted the fix-broken-travis-2233 branch April 3, 2019 18:39
@orbeckst

orbeckst commented Apr 3, 2019 via email

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants