Skip to content

Enable parallelization for analysis.polymer.PersistenceLength#4870

Closed
tanishy7777 wants to merge 0 commit into
MDAnalysis:developfrom
tanishy7777:develop
Closed

Enable parallelization for analysis.polymer.PersistenceLength#4870
tanishy7777 wants to merge 0 commit into
MDAnalysis:developfrom
tanishy7777:develop

Conversation

@tanishy7777

@tanishy7777 tanishy7777 commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Fixes #4671

Changes made in this Pull Request:

  • Enabled parallelization for PersistenceLength class
  • added tests (including fixtures in analysis/conftest.py)
  • update CHANGELOG

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4870.org.readthedocs.build/en/4870/

@pep8speaks

pep8speaks commented Dec 27, 2024

Copy link
Copy Markdown

Hello @tanishy7777! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 309:80: E501 line too long (86 > 79 characters)

Line 172:1: E302 expected 2 blank lines, found 1
Line 174:25: W292 no newline at end of file

Line 174:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-12-28 08:08:44 UTC

@tanishy7777

tanishy7777 commented Dec 27, 2024

Copy link
Copy Markdown
Contributor Author

I enabled parallization the way it was mentioned in PR #4682 and have read through this.

But I am unable to fix this AssertionError.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MDAnalysis.analysis.polymer: Implement parallelization or mark as unparallelizable

2 participants