So we keep having a discussion about this and I want to try and see if we can make a decision on this.
We/I have had many reports from users about MESA getting harder to evolve in versions post ~15140. I think some of this can be attributed to the tighter tolerances implied by use_gold_tolerances2=.true. in the defaults. While we want tighter controls in test cases to make sure MESA gets better, its not clear that forcing users to have this on in the defaults is beneficial, especially with people doing stellar engineering to models.
I propose we turn off gold_tolerances2 in the controls defaults and instead just add it to the test suite cases. That way it's clearer to users that this is an option they may want to enable/disable.
So we keep having a discussion about this and I want to try and see if we can make a decision on this.
We/I have had many reports from users about MESA getting harder to evolve in versions post ~15140. I think some of this can be attributed to the tighter tolerances implied by use_gold_tolerances2=.true. in the defaults. While we want tighter controls in test cases to make sure MESA gets better, its not clear that forcing users to have this on in the defaults is beneficial, especially with people doing stellar engineering to models.
I propose we turn off gold_tolerances2 in the controls defaults and instead just add it to the test suite cases. That way it's clearer to users that this is an option they may want to enable/disable.