Improve Wikidata test resiliency with retries and backoff#777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
timeand updatedtests/test_expansions.pyto implement a retry/backoff loop fortest_wikidatawithmax_attempts = 4andwait_seconds = 2.test_wikidatacatches and retries onrequests.exceptions.RequestExceptionand treats specific server-side error messages as retryable before failing the test."http://www.wikidata.org/entity/Q95","No additional data found on Wikidata", and the server error message) while reducing false negatives from transient network/API issues.Testing
pytest -q tests/test_expansions.py -k test_wikidatain this environment, which failed due to the local service being unreachable (Connection refusedto127.0.0.1:6666), indicating the failure is environmental and not caused by the test logic changes.Codex Task