Skip to content

Misp objects/#175 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haxpak wants to merge 3 commits into from
Closed

Misp objects/#175 #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89b8e10
added option "Further Analysis Required" to attribute stage
haxpak Apr 15, 2019
1c8d9db
modified attribute type of attribute "malware-sample" to "attachment"
haxpak Apr 16, 2019
93cd57b
removed typo
haxpak Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion objects/course-of-action/definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
"disable_correlation": true,
"sane_default": [
"Remedy",
"Response"
"Response",
"Further Analysis Required"
]
},
"cost": {
Expand Down
10 changes: 5 additions & 5 deletions objects/file/definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@
"recommended": false
},
"malware-sample": {
"description": "The file itself (binary)",
"ui-priority": 1,
"misp-attribute": "malware-sample"
Copy link
Member

@Rafiot Rafiot Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

malware-sample is definitely correct here, and working: https://github.com/MISP/PyMISP/blob/master/tests/testlive_comprehensive.py#L995

How are you using the object?

Copy link
Contributor Author

@haxpak haxpak Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to import a text file.
if I place the file as a non malicious plain attachment, it does not render it as an object, which cannot be refrenced with other objects

Copy link
Member

@Rafiot Rafiot Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use the API, or the web interface?

"description": "The file itself",
"ui-priority": 9,
"misp-attribute": "attachment"
},
"filename": {
"description": "Filename on disk",
Expand All @@ -122,7 +122,7 @@
"Payload installation",
"External analysis"
],
"ui-priority": 1,
"ui-priority": 10,
"misp-attribute": "filename"
},
"path": {
Expand Down Expand Up @@ -436,7 +436,7 @@
]
}
},
"version": 16,
"version": 17,
"description": "File object describing a file with meta-information",
"meta-category": "file",
"uuid": "688c46fb-5edb-40a3-8273-1af7923e2215",
Expand Down