Add support for Rails 7#23
Conversation
|
@jazairi I suspect this is fine, but can you confirm that it still works properly locally with both Rails 6 and Rails 7 apps before we merge and release it? Hit me up on Slack if you want any tips on how to do that. |
|
@JPrevost Confirmed that this does work on Rails 6 and Rails 7 by bundling the gem from source locally with Bento and TIMDEX UI. As we discussed this morning, there's some additional config required in Rails 7, which I'll include in my PR to add the theme gem to TIMDEX UI. Once thing I should mention is that the theme gem uses |
JPrevost
left a comment
There was a problem hiding this comment.
Please update the research ticket you noted in your comments so we don't forget to come back to that.
Can you also open ticket to add rails 7 layout features back to the layout template (I believe we'll lose Hotwire support if we use a Rails 6 app template but could be mistaken).
Why these changes are being introduced: This gem currently supports Rails 5 and 6 only, but we are starting to write applications that use Rails 7. Relevant ticket(s): MITLibraries/timdex-ui#16 How this addresses that need: This updates the gemspec to support versions of Rails greater than or equal to 5 but less than 8. Side effects of this change: * This gem still uses sassc, which appears to be unsupported. We should investigate whether it's possible to use a more modern CSS preprocessor (see #24). * Further work may be needed for the this gem to function alongside advanced Rails 7 UI features like Hotwire and Turbolinks (see #25).
Why these changes are being introduced:
This gem currently supports Rails 5 and 6 only, but we are starting
to write applications that use Rails 7.
Relevant ticket(s):
MITLibraries/timdex-ui#16
How this addresses that need:
This updates the gemspec to support versions of Rails greater than
or equal to 5 but less than 8.
Side effects of this change:
N/A.