Remove alt attribute from anchor in footer#30
Merged
Conversation
** Why are these changes being introduced: * This attribute has been flagged by ANDI throughout our identity, and it isn't needed - there is a screen-reader accessible text for this SVG image, as well as a title attribute in the SVG itself. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/engx-67 ** How does this address that need: * This removes the alt attribute ** Document any side effects to this change: * None
JPrevost
approved these changes
Jun 16, 2022
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
Ah... this makes sense. Thanks for digging into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
it isn't needed - there is a screen-reader accessible text for this
SVG image, as well as a title attribute in the SVG itself.
Relevant ticket(s):
How does this address that need:
Document any side effects to this change: