Skip to content

Remove Facebook and RSS links from footer#54

Merged
jazairi merged 1 commit into
mainfrom
uxws-1507-remove-fb-rss
Apr 3, 2023
Merged

Remove Facebook and RSS links from footer#54
jazairi merged 1 commit into
mainfrom
uxws-1507-remove-fb-rss

Conversation

@jazairi
Copy link
Copy Markdown
Contributor

@jazairi jazairi commented Mar 31, 2023

Why these changes are being introduced:

Communications have requested that we remove these links.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/UXWS-1507

How this addresses that need:

This removes the links from the footer layout.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

Communications have requested that we remove these links.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/UXWS-1507

How this addresses that need:

This removes the links from the footer layout.

Side effects of this change:

None.
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 31, 2023

Pull Request Test Coverage Report for Build 4578979797

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.372%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mitlibraries/theme/version.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 4440645644: 0.0%
Covered Lines: 38
Relevant Lines: 43

💛 - Coveralls

@JPrevost JPrevost self-assigned this Apr 3, 2023
@jazairi jazairi merged commit bbd5bb9 into main Apr 3, 2023
@jazairi jazairi deleted the uxws-1507-remove-fb-rss branch April 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants