feat: add ITF Transport Statistics and Japan e-Stat#44
Merged
firstdata-dev merged 3 commits intoMLT-OSS:mainfrom Mar 11, 2026
Merged
feat: add ITF Transport Statistics and Japan e-Stat#44firstdata-dev merged 3 commits intoMLT-OSS:mainfrom
firstdata-dev merged 3 commits intoMLT-OSS:mainfrom
Conversation
- itf-transport: International Transport Forum global transport statistics (road safety, freight/passenger volumes, infrastructure investment, CO2) - japan-estat: Japan's official statistics portal e-Stat with REST API (census, GDP, CPI, labor force, industrial statistics, 100k+ tables) Both sources validated and schema-compliant.
firstdata-dev
commented
Mar 11, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 两个高质量数据源,schema 完整(含 data_content),都有 API。建议合并。
mingcha-dev
reviewed
Mar 11, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #44
itf-transport (国际交通论坛) ✅
- HTTPS ✅, 有 API ✅
- country: null + geographic_scope: global ✅
- authority_level: international ✅
- data_content 完整(各10条)✅
- domain 问题:
statistics太泛,建议移除;infrastructure不在标准枚举 - tags 大小写/空格:
road safety、CO2 emissions等含空格,之前都用连字符
japan-estat (日本 e-Stat) ✅
- HTTPS ✅, 有 REST API ✅
- data_content 完整(各12条)✅ 内容很丰富
- domain 问题:
statistics和education不在标准枚举 - tags 大小写:
Japan、API等未小写 - 路径注意: 放在
countries/asia/japan/而非japan/,与 PR #40 的japan-customs(在japan/trade/)路径风格不一致
总结
内容质量明显比 #43 高很多,有完整的 data_content 👍 主要是 tags 大小写和 domain 标准化的老问题。不阻塞合并。
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Data Sources
1. ITF Transport Statistics (
itf-transport)firstdata/sources/international/transportation/itf-transport.json2. Japan e-Stat (
japan-estat)firstdata/sources/countries/asia/japan/japan-estat.jsonValidation