Skip to content

1.6.1#14

Merged
DerGoogler merged 30 commits into
masterfrom
1.6.1
Jul 12, 2023
Merged

1.6.1#14
DerGoogler merged 30 commits into
masterfrom
1.6.1

Conversation

@DerGoogler
Copy link
Copy Markdown
Collaborator

@DerGoogler DerGoogler commented Jul 7, 2023

Current changes

  • Added comments to modules (can also disabled via your module.prop file)
  • Added an Activity to view the module specs
  • Update NoRootActivity
  • Updated translations
  • Modules can now shared
  • Better support for large screens
  • Added Eruda console

Note

With the 1.6.1 update we're removing the option to download modules from the card. You'll have to open the module's readme to download the module.

Why?

There is a reason why module developers providing a readme for their module, you should read it and then download it.

Highlights

New Description API editor

Allows you preview description before you release it to MMRL!

Shows the new "No icon trick"

image

adds an way to module settings easier. it requires some improvements and an checked state
@DerGoogler DerGoogler linked an issue Jul 7, 2023 that may be closed by this pull request
Comment thread Android/app/src/main/assets/www/cordova.js Fixed
Comment thread Android/app/src/main/assets/www/cordova.js Fixed
Comment thread www/cordova.js
var term = "/cordova.js";
for (var n = scripts.length - 1; n > -1; n--) {
var src = scripts[n].src.replace(/\?.*$/, ""); // Strip any query param (CB-6007).
if (src.indexOf(term) === src.length - term.length) {

Check failure

Code scanning / CodeQL

Incorrect suffix check

This suffix check is missing a length comparison to correctly handle indexOf returning -1.
Comment thread www/cordova.js
function clobber(obj, key, value) {
var needsProperty = false;
try {
obj[key] = value;

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [src](1) to [obj](2) without guarding against prototype pollution.
@DerGoogler DerGoogler merged commit 0d14d04 into master Jul 12, 2023
@DerGoogler DerGoogler deleted the 1.6.1 branch July 12, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cordova backbutton not mounted Handle initial view in RepoActivity

2 participants