Fixing next serie of small problems (mainly found while handling Swiss data and filter) by ue71603 · Pull Request #92 · MMTIS/badger

ue71603 · 2026-01-16T23:42:44Z

Direction handled in the yield differently. This way it gets exported.
Reordered arguments in filter_db_to_db.py (same as used in the script_runner)
Handling the problem that Swiss JourneyMeeting and InterchangeRule don't result in valid ServiceJourneyInterchange (the only thing allowed in EPIP). We will discuss doing and transforming things with MENTZ.
commit to check by Stefan: 6a779c9
Adapting tests to do what is needed here
Fix a problem in test_runner.py

When we automatically generate direction, we need to store it. reorganised the yielding.

produces tons of log comments

allowed according to the epiprepository. also added a missing import: recurisve_attributes

…MMTIS/badger into fixing_direction_problem_filter

skinkie · 2026-01-20T10:24:59Z

I'll revamp this branch later.

skinkie · 2026-01-20T19:12:05Z

3022cfb @ue71603 unrelated!!

skinkie · 2026-07-22T20:06:33Z


-    def process(sjp: ServiceJourneyPattern, generator_defaults: dict[str, Any]) -> ServiceJourneyPattern | None:
+    def process(sjp: ServiceJourneyPattern, generator_defaults: dict[str, Any]) -> Generator[ServiceJourneyPattern | Direction, None, None] :
+        # TODO we should perhaps think about, if we should invent Direction. It is not mandatory.


The reason why we invent Direction is because IVU cannot import without it.

we removed the necessity in 2.1-wip. we will have to discuss this

Co-authored-by: Stefan de Konink <stefan@konink.de>

…em_filter

skinkie · 2026-07-25T21:20:15Z

    "paramiko",
    "types-paramiko",
    "tqdm",
+    "xsdata[cli,soap,lxml]>=25.7",


Here is a merging problem.

I know... Urs added also some cli code. I think this is feasible.

Co-authored-by: Stefan de Konink <stefan@konink.de>

…MMTIS/badger into fixing_direction_problem_filter

…em_filter

…MMTIS/badger into fixing_direction_problem_filter

…em_filter

…MMTIS/badger into fixing_direction_problem_filter

…em_filter

ue71603 · 2026-07-30T12:19:29Z

@skinkie do you merge the rest or say that you don't want some changes?

skinkie · 2026-07-30T12:57:30Z

I'll start reviewing the rest after what I am currently busy with.

ue71603 · 2026-08-01T21:07:35Z

@skinkie when you are done with the mp and the filter, then I think this needs to be addressed. I have some problems that are probably fixed here or needs to be addressed:
*
log1.md

Problem	Occurs in this branch?
conv.gtfs_import_to_db in eurostar. agengy.txt exists already	? but did not occur before
fix.day_offset in sta_bolzano	worked
Missing Directions e.g. in fr_aube	worked

ue71603 added 3 commits January 17, 2026 00:38

adding new filter test draft

81b6637

stefan: suggestion to not create Direction

2eda334

really saving direction when automatically generated

bae480f

When we automatically generate direction, we need to store it. reorganised the yielding.

ue71603 added this to the 2.0 milestone Jan 16, 2026

ue71603 added 2 commits January 17, 2026 01:00

changing order of arguments in filter_db_to_db.py target now second

237d034

fixing problem in filter1

124457c

skinkie reviewed Jan 17, 2026

View reviewed changes

Comment thread transformers/direction.py Outdated

ue71603 added 3 commits January 17, 2026 12:39

stefan: everything with yield now

d8b82d9

Update script_regression_v1.1.txt

2c10ed1

stefan: no forced order (if ok for you)

06ae4e2

skinkie reviewed Jan 17, 2026

View reviewed changes

Comment thread storage/lxml/core/insert.py Outdated

ue71603 added 13 commits January 17, 2026 13:36

stefan: some changes, to epip.py that you should check

6a779c9

order again written

4e162dd

produces tons of log comments

updating testing

47cd374

Update script_regression_v1.1.txt

dba721e

Update script_swiss_prod.txt

c5bfa52

rstrip is not to be used for this, removesuffix is the one needed

fb1987c

changing tests

74cad9e

stefan: keeping journey_meeting_and_interchangerule in the files

475ae58

allowed according to the epiprepository. also added a missing import: recurisve_attributes

updating tests

437074e

update scripts

e72e051

Update script_swiss_prod.txt

05e47e8

Update meta_test.txt

b37ac1d

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

670e5cf

…MMTIS/badger into fixing_direction_problem_filter

ue71603 changed the title ~~Trying to fix the problem with Direction~~ Fixing next step of problem Jan 20, 2026

ue71603 changed the title ~~Fixing next step of problem~~ Fixing next serie of small problems (mainly found while handling Swiss data and filter) Jan 20, 2026

skinkie reviewed Jan 21, 2026

View reviewed changes

Comment thread transformers/epip.py Outdated

adding new filter test draft

2ad02be

skinkie reviewed Jul 22, 2026

View reviewed changes

Comment thread transformers/direction.py Outdated

skinkie changed the base branch from binary_relation_serializer to main July 22, 2026 20:14

skinkie force-pushed the main branch from 18f9c9e to 9d6ad42 Compare July 22, 2026 20:34

skinkie changed the base branch from main to binary_relation_serializer July 22, 2026 20:41

ue71603 and others added 3 commits July 24, 2026 13:07

Apply suggestions from code review

dfb6cc4

Co-authored-by: Stefan de Konink <stefan@konink.de>

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

563a726

…em_filter

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

8f53b92

…em_filter

skinkie reviewed Jul 25, 2026

View reviewed changes

Comment thread transformers/gtfsprofile.py Outdated

skinkie reviewed Jul 25, 2026

View reviewed changes

Comment thread transformers/epip.py Outdated

skinkie and others added 7 commits July 25, 2026 23:23

Apply suggestions from code review

c8585d3

Co-authored-by: Stefan de Konink <stefan@konink.de>

fixing

c3638f5

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

a48a84e

…MMTIS/badger into fixing_direction_problem_filter

update regression script

ef793b3

fixing merge conflict in .toml file

0546089

Update script_regression_v1.1.txt

ca075d9

Update script_regression_v1.1.txt

603c419

ue71603 commented Jul 27, 2026

View reviewed changes

Comment thread transformers/direction.py Outdated

ue71603 added 8 commits July 27, 2026 22:33

Update transformers/direction.py

cb6e8a0

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

9edcdc7

…em_filter

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

cec3423

…MMTIS/badger into fixing_direction_problem_filter

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

7149939

…em_filter

Update script_regression_v1.1.txt

cec8305

Merge branch 'fixing_direction_problem_filter' of https://github.com/…

26b46d5

…MMTIS/badger into fixing_direction_problem_filter

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

01070e3

…em_filter

Merge branch 'binary_relation_serializer' into fixing_direction_probl…

4bcb3a8

…em_filter

Uh oh!

Conversation

ue71603 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

skinkie commented Jan 20, 2026

Uh oh!

Uh oh!

skinkie Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

ue71603 Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

skinkie Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

ue71603 Jul 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ue71603 commented Jul 30, 2026

Uh oh!

skinkie commented Jul 30, 2026

Uh oh!

ue71603 commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ue71603 commented Jan 16, 2026 •

edited

Loading