Skip to content

Fix duplicate stream detection in mpas_stream_list_insert #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgduda merged 3 commits into from
Oct 2, 2025
Merged

Fix duplicate stream detection in mpas_stream_list_insert #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3385a9
Add unit tests for mpas_stream_list module
Aug 15, 2025
b16dd8b
Fix bug allowing adjacent duplicate streams in mpas_stream_list insert
Aug 15, 2025
3f9ead8
Fix mpas_stream_list_insert bug unlinking head on duplicate insert
Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core_test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ OBJS = mpas_test_core.o \
mpas_test_core_string_utils.o \
mpas_test_core_dmpar.o \
mpas_test_core_stream_inquiry.o \
mpas_test_openacc.o
mpas_test_openacc.o \
mpas_test_core_stream_list.o

all: core_test

Expand Down Expand Up @@ -42,7 +43,8 @@ mpas_test_core.o: mpas_test_core_halo_exch.o mpas_test_core_streams.o \
mpas_test_core_field_tests.o mpas_test_core_timekeeping_tests.o \
mpas_test_core_sorting.o mpas_halo_testing.o \
mpas_test_core_string_utils.o mpas_test_core_dmpar.o \
mpas_test_core_stream_inquiry.o mpas_test_openacc.o
mpas_test_core_stream_inquiry.o mpas_test_openacc.o \
mpas_test_core_stream_list.o

mpas_test_core_halo_exch.o:

Expand Down
11 changes: 11 additions & 0 deletions src/core_test/mpas_test_core.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ function test_core_run(domain) result(iErr)!{{{
use mpas_vector_operations
use mpas_geometry_utils
use test_core_streams, only : test_core_streams_test
use mpas_test_core_stream_list, only : mpas_test_stream_list
use test_core_sorting, only : test_core_test_sorting
use mpas_halo_testing, only : mpas_halo_tests
use test_core_string_utils, only : mpas_test_string_utils
Expand Down Expand Up @@ -171,6 +172,16 @@ function test_core_run(domain) result(iErr)!{{{
else
call mpas_log_write('Stream tests: FAILURE', MPAS_LOG_ERR)
end if
call mpas_log_write('')

! Run stream list tests
call mpas_test_stream_list(iErr)
if (iErr == 0) then
call mpas_log_write('Stream list tests: SUCCESS')
else
call mpas_log_write('Stream list tests: FAILURE', MPAS_LOG_ERR)
end if
call mpas_log_write('')

! Run string util tests
call mpas_log_write('')
Expand Down
Loading