Conversation
…er_ints The 'pointer' attribute is unnecessary for the 'inlist' argument, and requiring the inlist argument to be a pointer precluded the use of mpas_dmpar_scatter_ints for arrays that are not pointers, e.g., allocatable arrays or array constructors. Additionally, since the inlist argument is used only as the first argument to MPI_Scatterv (i.e., as the 'sendbuf' argument of MPI_Scatterv), it can be declared as an intent(in) in the mpas_dmpar_scatter_ints routine. The changes in this commit have also been found to resolve runtime errors occurring with certain compiler and MPI library combinations, specifically, nvfortran and OpenMPI 5.x.
mgduda
force-pushed
the
framework/dmpar_scatter_dummy_pointer
branch
from
c832b38 to
9b9e5a5
Compare
Contributor
Author
|
The changes in this PR are expected to provide a suitable alternative to those in PR #1318 for the purposes of resolving issues in processing block decomposition files with OpenMPI 5.x and nvfortran. |
abishekg7
approved these changes
Aug 27, 2025
Collaborator
abishekg7
left a comment
abishekg7
left a comment
There was a problem hiding this comment.
Tested the changes with nvhpc/25.1 and openmpi/5.0.7 on Casper, and both the cpu and gpu builds appear to run fine on 4 MPI ranks.
The description seems sufficient too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
pointerattribute from theinlistdummy argument of thempas_dmpar_scatter_intsroutine.The
pointerattribute is unnecessary for theinlistargument, and requiring theinlistargument to be a pointer precluded the use ofmpas_dmpar_scatter_intsfor arrays that are not pointers, e.g., allocatable arrays or array constructors. Additionally, since theinlistargument is used only as the first argument toMPI_Scatterv(i.e., as thesendbufargument ofMPI_Scatterv), it can be declared as anintent(in)in thempas_dmpar_scatter_intsroutine.The changes in this PR have also been found to resolve runtime errors occurring with certain compiler and MPI library combinations, specifically, nvfortran and OpenMPI 5.x.