Fix premature assignment to optional argument before checking existence#1441
Merged
mgduda merged 1 commit intoMPAS-Dev:release-v8.4.0from Apr 9, 2026
Merged
Conversation
islas
commented
Apr 6, 2026
islas
force-pushed
the
bugfix_streammgr_optierr
branch
2 times, most recently
from
098a7c6 to
f0a4ba9
Compare
If no optional `ierr` argument is provided in calling the subroutine `mpas_get_stream_filename()` the model segfaults by trying to assign to the nonexistent argument. Additionally, `ierr` is set to zero to initialize, but as this module uses its own error codes it should instead use `MPAS_STREAM_MGR_NOERR`. This change checks if `ierr` is present, and if so initializes it to `MPAS_STREAM_MGR_NOERR`.
islas
force-pushed
the
bugfix_streammgr_optierr
branch
from
f0a4ba9 to
44ee2f8
Compare
mgduda
approved these changes
Apr 9, 2026
Contributor
mgduda
left a comment
mgduda
left a comment
There was a problem hiding this comment.
Thanks for the fix, and for spotting this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue within
mpas_get_stream_filename()where the optional argumentierrwas being assigned to before checking if it was passed in.The routine now checks if
ierris present, and if so initializes it toMPAS_STREAM_MGR_NOERR.