Skip to content

Fix crash in dynamics due to Fortran standard violation #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuanchihwang wants to merge 3 commits into
base: develop
Choose a base branch
from
+3 −3
Open

Fix crash in dynamics due to Fortran standard violation #1448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9164031
Fix Fortran standard violation due to pointer argument not being asso…
kuanchihwang Apr 21, 2026
0974d8e
Add missing argument intent
kuanchihwang Apr 21, 2026
2bef546
Avoid implicit `save` attribute during variable declaration
kuanchihwang Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core_atmosphere/dynamics/mpas_atm_time_integration.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1918,7 +1918,7 @@ subroutine atm_srk3(domain, dt, itimestep, exchange_halo_group)
type (mpas_pool_type), pointer :: diag_physics
type (mpas_pool_type), pointer :: mesh
type (mpas_pool_type), pointer :: tend
type (mpas_pool_type), pointer :: tend_physics => null()
type (mpas_pool_type), pointer :: tend_physics
type (mpas_pool_type), pointer :: lbc ! regional_MPAS addition

real (kind=RKIND), dimension(:,:), pointer :: w
Expand Down Expand Up @@ -5809,11 +5809,11 @@ subroutine atm_compute_dyn_tend(tend, tend_physics, state, diag, mesh, diag_phys
! Dummy arguments
!
type (mpas_pool_type), intent(inout) :: tend
type (mpas_pool_type), pointer :: tend_physics
type (mpas_pool_type), pointer, intent(in) :: tend_physics
type (mpas_pool_type), intent(in) :: state
type (mpas_pool_type), intent(in) :: diag
type (mpas_pool_type), intent(in) :: mesh
type (mpas_pool_type), intent(in) :: diag_physics
type (mpas_pool_type), pointer, intent(in) :: diag_physics
type (mpas_pool_type), intent(in) :: configs
integer, intent(in) :: nVertLevels ! for allocating stack variables
integer, intent(in) :: rk_step, dynamics_substep
Expand Down