This repository was archived by the owner on Oct 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Moving particle routines from analysis members to shared #1468
Open
davelee2804
wants to merge
6
commits into
MPAS-Dev:ocean/develop
Choose a base branch
from
davelee2804:ocean/light_particle_reorg
base: ocean/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d2bef5a
initial commit of the new particle reorg branch
e43d4e7
adding particle helpers module to the makefile
19e5bc3
1) deleting lagrangian particles version of the wachspress initialzat…
d320b8e
additional changes to particle pull request to facilitate removal of …
0413eb1
removing old version of the particle_horiztonal_movement routine
6be3c95
cleaning up the spherical triangle area routine
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -248,9 +248,6 @@ | |
| <var name="buoyancySurfaceValues" type="real" dimensions="nBuoyancySurfaces" units="kg m^{-3}" | ||
| description="definition of buoyancy surfaces in terms of potential density" | ||
| /> | ||
| <var name="wachspressAreaB" type="real" dimensions="nCells maxEdges" units="m^2" | ||
| description="cached polygon subarea B_i used in Wachspess calculation" | ||
| /> | ||
| </var_struct> | ||
| <var_struct name="lagrPartTrackHalo" time_levs="1" packages="lagrPartTrackAMPKG"> | ||
| <var name="ioBlock" type="integer" dimensions="nParticles" units="unitless" | ||
|
|
@@ -350,49 +347,3 @@ | |
| description="v velocity of particle - meridional direction" | ||
| /> | ||
| </var_struct> | ||
| <var_struct name="lagrPartTrackNonHalo" time_levs="1" packages="lagrPartTrackAMPKG"> | ||
| </var_struct> | ||
| <var_struct name="lagrPartTrackScratch" time_levs="1" packages="lagrPartTrackAMPKG"> | ||
| <var name="ucReconstructX" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="reconstructed cell center velocity- x component" | ||
| /> | ||
| <var name="ucReconstructY" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="reconstructed cell center velocity- y component" | ||
| /> | ||
| <var name="ucReconstructZ" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="reconstructed cell center velocity- z component" | ||
| /> | ||
| <var name="ucTemp" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="cell velocity" | ||
| /> | ||
| <var name="ucX" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="cell velocity- x component" | ||
| /> | ||
| <var name="ucY" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="cell velocity- y component" | ||
| /> | ||
| <var name="ucZ" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="cell velocity- z component" | ||
| /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, please leave. |
||
| <var name="uvX" type="real" dimensions="nVertLevels nVertices" units="m s^{-1}" | ||
| description="vertex velocity- x component" | ||
| /> | ||
| <var name="uvY" type="real" dimensions="nVertLevels nVertices" units="m s^{-1}" | ||
| description="vertex velocity- y component" | ||
| /> | ||
| <var name="uvZ" type="real" dimensions="nVertLevels nVertices" units="m s^{-1}" | ||
| description="vertex velocity- z component" | ||
| /> | ||
| <var name="ucReconstructMeridional" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="reconstructed cell center velocity- meridional component" | ||
| /> | ||
| <var name="ucReconstructZonal" type="real" dimensions="nVertLevels nCells" units="m s^{-1}" | ||
| description="reconstructed cell center velocity- zonal component" | ||
| /> | ||
| <var name="boundaryVertexGlobal" type="integer" dimensions="nVertLevels nVertices" units="unitless" | ||
| description="Mask for determining boundary vertices, but global. A boundary vertex has at least one inactive cell neighboring it." | ||
| /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, please leave. |
||
| <var name="boundaryCellGlobal" type="integer" dimensions="nVertLevels nCells" units="unitless" | ||
| description="Mask for determining boundary cells, but global. A boundary cell has at least one inactive cell neighboring it." | ||
| /> | ||
| </var_struct> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davelee2804, I think these have to be left here, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need them to advect particles.