Skip to content

Sort mesh indices before saving culled global ocean meshes#657

Merged
xylar merged 1 commit intoMPAS-Dev:mainfrom
xylar:sort-mesh-indices
Aug 9, 2023
Merged

Sort mesh indices before saving culled global ocean meshes#657
xylar merged 1 commit intoMPAS-Dev:mainfrom
xylar:sort-mesh-indices

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jul 26, 2023

We need to create the graph file only after sorting has happened.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging labels Jul 26, 2023
@xylar xylar self-assigned this Jul 26, 2023
@xylar
Copy link
Collaborator Author

xylar commented Jul 26, 2023

Tesitng

So far, the ecwisc30to60 test suite has run successfully (except for the failing validation in #331) through the dynamic_adjustment phase using this branch!

I'm still running files_for_e3sm but don't expect any surprises there.

We need to create the graph file only after sorting has happened.
@xylar xylar force-pushed the sort-mesh-indices branch from 4baabc2 to a3ba192 Compare August 8, 2023 12:06
@xylar xylar marked this pull request as ready for review August 8, 2023 12:06
@xylar
Copy link
Collaborator Author

xylar commented Aug 8, 2023

Further testing

After updating to the released MPAS-Tools package in #662, I'm retesting through files_for_e3sm with the following meshes:

@xylar xylar merged commit 1b820d3 into MPAS-Dev:main Aug 9, 2023
@xylar xylar deleted the sort-mesh-indices branch August 9, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request in progress This PR is not ready for review or merging ocean

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant