Skip to content

Add a step for remapping iceberg climatologies #677

Merged
xylar merged 5 commits intoMPAS-Dev:mainfrom
xylar:add-iceberg-climatology
Aug 25, 2023
Merged

Add a step for remapping iceberg climatologies #677
xylar merged 5 commits intoMPAS-Dev:mainfrom
xylar:add-iceberg-climatology

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Aug 21, 2023

This is used in E3SM runs with data iceberg freshwater fluxes.

Checklist

  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean labels Aug 21, 2023
@xylar xylar self-assigned this Aug 21, 2023
@xylar xylar force-pushed the add-iceberg-climatology branch from f568731 to d600476 Compare August 21, 2023 13:10
xylar added 3 commits August 21, 2023 20:55
This is used in E3SM runs with data iceberg freshwater fluxes.
There is a bug fix to `LatLon2DGridDescriptor` in `pyremap` v1.0.1
that we need to be able to create a valid scrip file for the
iceberg source dataset.
@xylar xylar force-pushed the add-iceberg-climatology branch from ea17dd3 to 041e363 Compare August 21, 2023 18:55
@xylar
Copy link
Collaborator Author

xylar commented Aug 21, 2023

I'm seeing a seam at +/- 180 so I need to figure out what's going wrong there. Probably the non-monotonic longitude.

output_with_seam

@xylar xylar force-pushed the add-iceberg-climatology branch 5 times, most recently from 11a3034 to c8fb937 Compare August 21, 2023 20:18
@xylar xylar force-pushed the add-iceberg-climatology branch from c8fb937 to 6ce9dbe Compare August 21, 2023 20:35
@xylar
Copy link
Collaborator Author

xylar commented Aug 21, 2023

Okay, finally got rid of the seam:
output_no_seam

@jonbob
Copy link
Collaborator

jonbob commented Aug 21, 2023

I remember the same issue when Darin and I were first working on this....

@xylar
Copy link
Collaborator Author

xylar commented Aug 21, 2023

There really is a block of zeros on the east and west sides of the data!

@xylar xylar requested review from darincomeau and jonbob August 21, 2023 21:00
@xylar
Copy link
Collaborator Author

xylar commented Aug 21, 2023

@jonbob and @darincomeau, I'm not necessarily asking for a review of the code here (though that's fine if you want to). But it would be nice to have you double check that the 4 files:

/lcrc/group/e3sm/data/inputdata/ice/mpas-seaice/ECwISC30to60E3r1/Iceberg_Climatology_Merino.ECwISC30to60E3r1.20230815.nc
/lcrc/group/e3sm/data/inputdata/ice/mpas-seaice/IcoswISC30E3r1/Iceberg_Climatology_Merino.IcoswISC30E3r1.20230815.nc
/lcrc/group/e3sm/data/inputdata/ice/mpas-seaice/RRSwISC6to18E3r1/Iceberg_Climatology_Merino.RRSwISC6to18E3r1.20230818.nc
/lcrc/group/e3sm/data/inputdata/ice/mpas-seaice/SOwISC12to60E3r1/Iceberg_Climatology_Merino.SOwISC12to60E3r1.20230815.nc

look okay by whatever approach you would like to take to look at them. I looked at January of Iceberg_Climatology_Merino.IcoswISC30E3r1.20230815.nc in paraview but that's the most I've done so far.

@xylar
Copy link
Collaborator Author

xylar commented Aug 21, 2023

Testing

I ran the files_for_e3sm/remap_iceberg_climatology step designed for existing meshes for the 4 meshes listed above. I also ran it for the Icos240E3r1 within the full compass mesh generation workflow. All test cases succeeded in producing the desired output file, and the Icos240E3r1 and IcoswISC30E3r1 January outputs looked as expected in Paraview.

@xylar
Copy link
Collaborator Author

xylar commented Aug 24, 2023

@jonbob and @darincomeau, unless you have feedback on the iceberg melt files, I think I'll merge this based on my testing.

@xylar xylar removed request for darincomeau and jonbob August 25, 2023 07:29
@xylar xylar merged commit d62a0b0 into MPAS-Dev:main Aug 25, 2023
@xylar xylar deleted the add-iceberg-climatology branch August 25, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ocean

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants