Skip to content

feat: added ntSynt and ntSynt-viz for synteny analysis + bug fix#16

Open
rabioinf wants to merge 9 commits intomainfrom
dev
Open

feat: added ntSynt and ntSynt-viz for synteny analysis + bug fix#16
rabioinf wants to merge 9 commits intomainfrom
dev

Conversation

@rabioinf
Copy link
Copy Markdown
Member

No description provided.

@rabioinf rabioinf requested a review from m-jahn April 22, 2026 16:34
@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@rabioinf rabioinf marked this pull request as draft April 22, 2026 16:58
@rabioinf rabioinf marked this pull request as draft April 22, 2026 16:58
Comment thread workflow/envs/ntsynt.yml Outdated
Comment thread workflow/rules/qc.smk
Comment thread workflow/rules/qc.smk Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@rabioinf rabioinf marked this pull request as ready for review April 23, 2026 11:44
@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions
Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@m-jahn m-jahn self-requested a review April 24, 2026 09:57
f"Error reading sample sheet from {snakemake.params['sample_sheet']}: {e}\n"
)

df_samples["file"] = df_samples["file"].apply(lambda x: os.path.basename(x))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this script produced an error for me because my sample names are numbers, which is not not something completely out of the ordinary. Here we need to add type coercion to make this robust, add line:

df_samples["sample"] = df_samples["sample"].apply(lambda x: str(x))

Comment thread workflow/rules/qc.smk
Comment on lines +302 to +304
rsync ./ntSynt.* {params.outdir}/;
rsync ./ntSynt-viz.* {params.outdir}/;
rsync ./ntSynt-viz_* {params.outdir}/;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why rsync and not just cp or mv? Isn't rsync another dependency which would be unnecessary just to copy files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants