Skip non-workload documents instead of aborting the stream - #54
Open
MPV wants to merge 1 commit into
Open
Conversation
This was referenced Jul 23, 2026
MPV
force-pushed
the
claude/skip-non-workloads
branch
from
July 23, 2026 07:09
e896ac0 to
82b2362
Compare
MPV
force-pushed
the
claude/stdin-multidoc
branch
from
July 23, 2026 08:17
8f215aa to
8696395
Compare
MPV
force-pushed
the
claude/skip-non-workloads
branch
from
July 23, 2026 08:17
82b2362 to
aad8d56
Compare
MPV
force-pushed
the
claude/stdin-multidoc
branch
from
July 23, 2026 08:24
8696395 to
6e5fb8d
Compare
This was referenced Jul 23, 2026
MPV
force-pushed
the
claude/skip-non-workloads
branch
from
July 23, 2026 08:52
aad8d56 to
aebe427
Compare
MPV
force-pushed
the
claude/stdin-multidoc
branch
from
July 24, 2026 06:45
6e5fb8d to
c2e30c5
Compare
MPV
force-pushed
the
claude/skip-non-workloads
branch
from
July 24, 2026 06:45
aebe427 to
ab391dc
Compare
This was referenced Aug 2, 2026
MPV
force-pushed
the
claude/stdin-multidoc
branch
from
August 2, 2026 08:00
c2e30c5 to
b19278d
Compare
Previously any document whose kind had no PodSpec (a Service, ConfigMap, etc.) made ProcessData return an error, which aborted the whole file and discarded images already collected from earlier documents. A single Service alongside real workloads produced no output at all. Treat non-workload kinds as skippable: return no images and no error for them, and likewise for kinds not registered in the scheme (CRDs and other custom resources). Images from the surrounding workloads are preserved. The former TestError (which asserted a Service errored) becomes TestSkipsNonWorkloads, and TestMixed covers a workload+Service+workload file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC
MPV
force-pushed
the
claude/skip-non-workloads
branch
from
August 2, 2026 08:00
ab391dc to
050d1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat documents whose kind has no PodSpec (Service, ConfigMap, …) — and kinds not registered in the scheme (CRDs / custom resources) — as skippable: return no images and no error for them.
Why
Previously any such document made
ProcessDatareturn an error, which aborted the whole file and discarded images already collected from earlier documents. A single Service alongside real workloads produced no output at all.Behavior change
Non-workload documents are skipped; images from surrounding workloads are preserved. A file/stream containing only non-workloads now succeeds with empty output rather than erroring.
How it reads in review
Because #59 made the suite approve stderr too (via the shared
verify()helper), this behavior change lands as a golden diff:TestErrorbecomesTestSkipsNonWorkloads, and its stderr golden goes fromerror processing document: unsupported kind Service→ empty.TestMixed(also viaverify()) covers a workload + Service + workload file.Stack
Base:
claude/stdin-multidoc(#49). Merge order: #59 → #49 → this →claude/robust-yaml-splitting(#56).🤖 Generated with Claude Code
https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC