Skip to content

mpol.utils.convert_baselines and mpol.utils.broadcast_and_convert_baselines duplicate visread functionality #227

@iancze

Description

@iancze

Is your feature request related to a problem or opportunity? Please describe.
The two utility routines mpol.utils.convert_baselines and mpol.utils.broadcast_and_convert_baselines duplicate functionality that is provided by visread. This creates another source of code to maintain. IIRC, we originally duplicated this into MPoL this because a) we want to store visibility datasets using baselines measured in meters because if nchan > 1 it is a more efficient way to store them than lambda (all baselines are the same in meters, but lambda values change when observing frequency changes) and b) we don't want to require visread as a dependency of MPoL because as it's currently implemented, visread has a core dependency of casatools, which significantly restricts the ability to install MPoL into modern compute environments. However...

Describe the solution you'd like
... I think a better solution is to reorganize visread into a set of minimal functionality (including these aforementioned routines) that does not require casatools. The larger set of visread functionality can be maintained through a pip install visread[casa] install, and cleanly separated into their own module imports. It may or may not make sense to add the minimal visread to the core set of MPoL dependencies, since this is not really core MPoL functionality, it's more of a data prep helper.

How might you be able to help with the development of this feature?
I'll do this to visread.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions