GridCoords constructor with @properties and @cached_properties#187
Closed
kadri-nizam wants to merge 8 commits intoMPoL-dev:mainfrom
Closed
GridCoords constructor with @properties and @cached_properties#187kadri-nizam wants to merge 8 commits intoMPoL-dev:mainfrom
@properties and @cached_properties#187kadri-nizam wants to merge 8 commits intoMPoL-dev:mainfrom
Conversation
iancze
reviewed
Apr 6, 2023
iancze
reviewed
Apr 6, 2023
iancze
reviewed
Apr 6, 2023
iancze
reviewed
Apr 6, 2023
iancze
approved these changes
Apr 6, 2023
Collaborator
iancze
left a comment
iancze
left a comment
There was a problem hiding this comment.
I think this looks good and is ready to merge, but would appreciate finding a different variable for spatial frequency than f, preferably one that retains interpretability as u or v.
iancze
reviewed
Apr 6, 2023
Co-authored-by: Ian Czekala <iczekala@psu.edu>
iancze
added a commit
that referenced
this pull request
Jan 5, 2024
Updated #187: GridCoords constructor with `@properties` and `@cached_properties`
Collaborator
|
Merged into WIP-v0.3 branch by updated #250 . Thanks for the contribution, @kadri-nizam ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #152
Repeated identical calculations for defining certain attributes are now done only once in the constructor and accessed via
@properties. Non-identical attributes are set as@cached_propertiesand only computed once on first call.