Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.from_image_propertiesclass method #233. Removed convenience classmethodsfrom_image_propertiesfrom across the code base. The recommended workflow is to create a :class:mpol.coordinates.GridCoordsobject and pass that to instantiate these objects as needed, rather than passingcell_sizeandnpixseparately. For nearly all but trivially short workflows, this simplifies the number of variables the user needs to keep track and pass around revealing the central role of the :class:mpol.coordinates.GridCoordsobject and its useful attributes for image extent, visibility extent, etc. Most importantly, this significantly reduces the size of the codebase and the burden to maintain, test, and document multiple entry points to keynn.modules. We removedfrom_image_propertiesfrommpol.datasets.GriddedDatasetmpol.datasets.Dartboardmpol.fourier.NuFFTmpol.fourier.NuFFTCachedmpol.fourier.FourierCubempol.gridding.GridderBasempol.gridding.DataAveragermpol.gridding.DirtyImagermpol.images.BaseCubempol.images.ImageCubenn.Parameterfrom ImageCube #246 Make thepassthroughbehaviour of :class:mpol.images.ImageCubethe default and removed this parameter entirely. Previously, it was possible to have :class:mpol.images.ImageCubeact as a layer withnn.Parameters. This functionality has effectively been replaced since the introduction of :class:mpol.images.BaseCubewhich provides a more useful way to parameterize pixel values. If a one-to-one mapping (including negative pixels) fromnn.Parameters to output tensor is desired, then one can specifypixel_mapping=lambda x : xwhen instantiating :class:mpol.images.BaseCube.mpol.utils.log_stretch.