Fix loss function bugs and inconsistencies#247
Merged
Conversation
…rch adaptation, but still distinct from eht imaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feature branch on top of WIP-v0.3 (original PR #243, since split off into incremental bits)
Scope of this branch is fixing loss function bugs and inconsistencies, aiming to close
* #237
* #153
* #100
mpol.losses.neg_log_likelihood_avgmethod to be used in point-estimate or optimization situations where data amplitudes or weights may be adjusted as part of the optimization (such as via self-calibration). Moved all documentation around loss functions into the Losses API.mpol.losses.nll->mpol.losses.r_chi_squaredandmpol.losses.nll_gridded->mpol.losses.r_chi_squared_griddedbecause that is what those routines were previously calculating (see theapi-reference-labelfor more details). (#237). Tutorials have also been updated to reflect the change.mpol.losses.log_likelihood(#237).