Skip to content

Fix loss function bugs and inconsistencies#247

Merged
iancze merged 19 commits intoWIP-v0.3from
loss-correction
Dec 29, 2023
Merged

Fix loss function bugs and inconsistencies#247
iancze merged 19 commits intoWIP-v0.3from
loss-correction

Conversation

@iancze
Copy link
Copy Markdown
Collaborator

@iancze iancze commented Dec 27, 2023

A feature branch on top of WIP-v0.3 (original PR #243, since split off into incremental bits)

Scope of this branch is fixing loss function bugs and inconsistencies, aiming to close
* #237
* #153
* #100

  • Expanded scope to include major documentation edits to be more concise with the objective of making the core package easier to develop and maintain. Some tutorials moved to the MPoL-dev/examples repository.
  • Added the mpol.losses.neg_log_likelihood_avg method to be used in point-estimate or optimization situations where data amplitudes or weights may be adjusted as part of the optimization (such as via self-calibration). Moved all documentation around loss functions into the Losses API.
  • Renamed mpol.losses.nll -> mpol.losses.r_chi_squared and mpol.losses.nll_gridded -> mpol.losses.r_chi_squared_gridded because that is what those routines were previously calculating (see the api-reference-label for more details). (#237). Tutorials have also been updated to reflect the change.
  • Fixed implementation and docstring of {meth}mpol.losses.log_likelihood (#237).

@iancze iancze marked this pull request as ready for review December 29, 2023 23:20
@iancze iancze merged commit dee9128 into WIP-v0.3 Dec 29, 2023
@iancze iancze deleted the loss-correction branch December 29, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant