Rename manifest.json to paimonmoe.webmanifest#395
Open
jogerj wants to merge 2 commits intoMadeBaruna:mainfrom
Open
Rename manifest.json to paimonmoe.webmanifest#395jogerj wants to merge 2 commits intoMadeBaruna:mainfrom
jogerj wants to merge 2 commits intoMadeBaruna:mainfrom
Conversation
Antosik
reviewed
Mar 13, 2023
| rel="stylesheet" | ||
| /> | ||
| <link rel="manifest" href="/paimonmoe.webmanifest" crossorigin="use-credentials" /> | ||
| <link rel="manifest" href="/manifest.json" crossorigin="use-credentials" /> |
There was a problem hiding this comment.
Should we remove this one? If it was renamed
Author
There was a problem hiding this comment.
Not sure if it will break functionality. My intuition says no, but having both is also harmless. Removing it will not stop vite from generating it nor make it unreachable (for that you'll have to config the routes to direct it to null/404)
|
Same as #392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #394
See https://developer.mozilla.org/en-US/docs/Web/Manifest#deploying_a_manifest