Add location config option to SMHI weather provider#125
Merged
MichMich merged 2 commits intoOct 2, 2022
Conversation
rejas
reviewed
Aug 30, 2022
| | `lat` | The latitude coordinate for the desired location. <br><br> **Possible value:** `59.322665376` <br> This value is **REQUIRED** | | ||
| | `lon` | The longitude coordinate for the desired location. <br><br> **Possible value:** `18.069666388` <br> This value is **REQUIRED** | | ||
| | `precipitationValue` | The type of precipitation to display (min, max, median, mean). <br><br> **Possible values:** `'pmin'` , `'pmean'` , `'pmedian'`, `'pmax'`. <br> **Default value:** `'pmedian'` | | ||
| | `location` | The location used for weather information. <br><br> **Example:** `'Stockholm'` <br> **Default value:** `false` <br><br> | |
Collaborator
There was a problem hiding this comment.
Is there an URL where one can look up all available locations? That would be helpful here :-)
Contributor
Author
There was a problem hiding this comment.
This is a display name only, I used the name location because that seems to be what has been used previously.
Should I add a short clarification about this?
Collaborator
There was a problem hiding this comment.
Yeah, that may be helpful, something like "The name displayed on top of the weather informaion"
Contributor
Author
There was a problem hiding this comment.
Sorry for the delay! Is that better?
rejas
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to keep the docs up-to-date with MagicMirrorOrg/MagicMirror#2902