Update WeatherProvider documentation#138
Merged
Merged
Conversation
khassel
approved these changes
Jan 12, 2023
Collaborator
Author
|
This would have to be merged now since the changes are already released in the current MM version @khassel |
Collaborator
Author
|
Thx. Should we do the "squahs&merge" tactic here too btw? |
Collaborator
|
from my side, yes. There are now still 3 PR's open all with conflicts in weather.md, can you take a look into this? |
Collaborator
Author
Already on it ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reworking the unit handling in MagicMirrorOrg/MagicMirror#2849 we need to update the docs