ci: run PR checks also for develop PRs#388
Merged
Merged
Conversation
khassel
approved these changes
Jun 29, 2026
rejas
added a commit
that referenced
this pull request
Jul 1, 2026
* docs: improve autostart guide with user systemd service for full Electron UI (#345) * Update autostart.md Improve autostart documentation: add user systemd service for full Electron UI with logging and environment variables * Update autostart.md docs: address PR feedback — clarify display server and disable logging by default * Update autostart.md docs: verified the environment inherited by systemd --user, ensured DISPLAY=:0 and WAYLAND_DISPLAY=wayland-0 is set up automatically * Update autostart.md docs: updated Troubleshooting section * clarify systemd service behavior + minor changes - Add platform note: Clarify guide is for Raspberry Pi OS Desktop - Fix typo: WAYLAND_DIAPLAY → WAYLAND_DISPLAY - Fix misleading comment: System services start on boot, not after user login - Remove trailing whitespace and newline --------- Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> * style: set carbon ads background color to inherit (#350) * location of default modules changed (#353) see MagicMirrorOrg/MagicMirror#4019 * move custom.css from css to config (#354) * update variables in config * add secrets.md * fix typo * add missing " * node_modules/vitepress/types/default-theme.d.ts * apply Prettier formatting * handle cspell issues * add weatherapi options to weather module configuration (#359) * docs(compliments): clarify remoteFile path resolution and limitations (#360) * docs: correct loaded() - server-side only, not a client-side hook (#361) Document that loaded() belongs to node_helper, not Module. Add async/Promise support to the start() docs as the correct way to handle asynchronous module initialization. * docs: clarify that public folder requires node_helper.js (#362) * docs: explain physical concept and hardware scope on landing page (#365) Add a short paragraph to index.md that explains what a MagicMirror physically is, clarifies that this documentation covers the software side only, and points newcomers to the community showcase for hardware build inspiration. Closes MagicMirrorOrg/MagicMirror#3282 * add weather templates (#366) * weather: add themes example * calendar: align showEnd and dateEndFormat defaults (#368) * fix failing tests * documentation for secrets and cors (#374) * Add Buienradar weather provider (#382) * docs(introduction): clarify usage of functions in config.js for browser availability * docs(introduction): add export statement for config in config.js example * chore: update devDependencies (#386) * newsfeed: document allowedBasicHtmlTags option (#387) * ci: run PR checks also for develop PRs (#388) * ci: run PR checks also for develop PRs * ci: update checkout action to v7 * ci: add dependabot config * chore: add prettier-ignore comments to prevent line break --------- Co-authored-by: Github Actions <actions@github.com> Co-authored-by: Станислав <52878917+vectorman115@users.noreply.github.com> Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Co-authored-by: Karsten Hassel <hassel@gmx.de> Co-authored-by: veeck <gitkraken@veeck.de> Co-authored-by: sam detweiler <sdetweil@gmail.com> Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com> Co-authored-by: Morgan McBee <egeekial@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last PR, I noticed this repo wasn't running checks for PRs targeting
develop. This PR enables those checks, updates the GitHub Actions versions, and adds a dependabot config.With the dependabot config, dependency update PRs should target
developinstead ofmaster(as seen in #378).Update:
The fourth commit was a fix for a formatting issue. The issue wouldn't have been noticed until the release - which would have been too late, because we don't really want to be dealing with formatting issues at the time of release. So this PR itself has become a good example of why it makes sense :)